Skip to content

Immutable artifact markers#91

Merged
xFrednet merged 3 commits intoimmutable-mainfrom
immutable-artifact-markers
Mar 17, 2026
Merged

Immutable artifact markers#91
xFrednet merged 3 commits intoimmutable-mainfrom
immutable-artifact-markers

Conversation

@xFrednet
Copy link
Collaborator

This PR adds markers for the artifact, the output roughly looks like this:

@mjp41 Are there any interesting implementation details I forgot?

Tests

Implementation

@xFrednet xFrednet force-pushed the immutable-artifact-markers branch 3 times, most recently from 4678c22 to 0480192 Compare March 16, 2026 23:23
@mjp41
Copy link
Collaborator

mjp41 commented Mar 17, 2026

This looks like a great set. I guess we could split up the freeze implementation a bit, but it is a tricky piece of code, and I am not sure these sign posts would be sufficient.

@xFrednet
Copy link
Collaborator Author

xFrednet commented Mar 17, 2026

I find the code pretty readable, and therefore the markers sufficient, but this is very likely due to too much kool-aid

@xFrednet xFrednet force-pushed the immutable-artifact-markers branch from e653d9b to 2c90688 Compare March 17, 2026 10:45
@xFrednet xFrednet merged commit d5b515f into immutable-main Mar 17, 2026
26 of 34 checks passed
@xFrednet xFrednet deleted the immutable-artifact-markers branch March 17, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants